search

brandonbloom / fipp

Fast Idiomatic Pretty Printer for Clojure
525 stars 44 forks source link

Optional println? #61

Closed venantius closed 5 years ago

venantius commented 5 years ago

I was wondering if you'd be open to making the newline generated here optional: https://github.com/brandonbloom/fipp/blob/master/src/fipp/engine.cljc#L245. This is motivated in part by my looking for naive workarounds to this - https://github.com/greglook/whidbey/issues/30; let me know if I'm just barking up the wrong tree here.

brandonbloom commented 5 years ago

I can't think of any situation where I wouldn't want a trailing newline in pretty-printed output. Other than, of course, when somebody else is already providing one.

My intuition is that the newline should be non-optionally excluded downstream (nrepl or wherever), not made optional here in Fipp.

Let me know if you think that this is way off base.