Handle java.sql.Timestamp corner case

brandonbloom / fipp

Fast Idiomatic Pretty Printer for Clojure

525 stars 44 forks source link

Handle java.sql.Timestamp corner case #78

Closed vemv closed 3 years ago

vemv commented 3 years ago

Fixes https://github.com/brandonbloom/fipp/issues/72

vemv commented 3 years ago

Hi @brandonbloom sorry to bother, do you have the chance to review this one again?

Ideally I could use fipp for an important feature that we want to implement at cider-nrepl

brandonbloom commented 3 years ago

I'll set a reminder to check it out this weekend.

brandonbloom commented 3 years ago

I merged this, but I also made a few follow-up commits for stylistic things as well as some CLJS breakage (which is likely not your fault!) and added CLJS to CI. Please try v0.6.24 and let me know if it does or does not work as you expect. Thanks!

vemv commented 3 years ago

Thanks so much for your time and refinements!

0.6.24 is working as expected 👍