Closed brandon-leapyear closed 4 years ago
Merging #49 into master will increase coverage by
0.13%
. The diff coverage is95.23%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 87.36% 87.50% +0.13%
==========================================
Files 12 12
Lines 451 456 +5
Branches 17 17
==========================================
+ Hits 394 399 +5
Misses 50 50
Partials 7 7
Impacted Files | Coverage Δ | |
---|---|---|
src/Data/Aeson/Schema/TH/Utils.hs | 69.66% <92.85%> (+0.69%) |
:arrow_up: |
src/Data/Aeson/Schema/TH/Schema.hs | 92.59% <100.00%> (ø) |
|
src/Data/Aeson/Schema/Type.hs | 93.10% <100.00%> (+0.79%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b83f61e...0448f9d. Read the comment docs.
:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:
44 broke the use-case where a schema uses an imported scalar type in module A, which is included in a schema in module B:
This broke because we now completely reify included schemas as if the schema were defined inline.
This PR adds a
NameLike
feature where SchemaScalars can be either aString
(referencing a type that must be imported) or aName
which is persisted after reifying a SchemaScalar.