brandonchinn178 / aeson-schemas

Easily consume JSON data on-demand with type-safety
http://hackage.haskell.org/package/aeson-schemas
BSD 3-Clause "New" or "Revised" License
52 stars 1 forks source link

Some clean up in get quasiquoter #52

Closed brandon-leapyear closed 3 years ago

brandon-leapyear commented 3 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:


Separate the logic for "what function(s) should be called at runtime" from "how should the function(s) be applied wrt subsequent functions". Works a lot more nicely with the new NonEmpty types

codecov-commenter commented 3 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files          12       12           
  Lines         473      473           
  Branches       21       21           
=======================================
  Hits          412      412           
  Misses         52       52           
  Partials        9        9           
Impacted Files Coverage Δ
src/Data/Aeson/Schema/TH/Unwrap.hs 90.90% <ø> (ø)
src/Data/Aeson/Schema/TH/Get.hs 82.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa1b734...bb5d2f6. Read the comment docs.