search

brandonchinn178 / aeson-schemas

Easily consume JSON data on-demand with type-safety
http://hackage.haskell.org/package/aeson-schemas
BSD 3-Clause "New" or "Revised" License
52 stars 1 forks source link

Add more benchmarks #54

Closed brandon-leapyear closed 3 years ago

brandon-leapyear commented 3 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

Add benchmarks for the FromJSON, ToJSON, and Show instances.

Turns out Show had quadratic performance due to (++), so I updated showValue to return ShowS instead (thanks to u/qseep for the advice!)

codecov-commenter commented 3 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.12%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   87.10%   86.97%   -0.13%     
==========================================
  Files          12       12              
  Lines         473      476       +3     
  Branches       21       21              
==========================================
+ Hits          412      414       +2     
- Misses         52       53       +1     
  Partials        9        9
Impacted Files Coverage Δ
src/Data/Aeson/Schema/Key.hs 88.23% <0.00%> (-5.52%) :arrow_down:
src/Data/Aeson/Schema/Internal.hs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad13a2e...163f893. Read the comment docs.