search

brandondube / prysm

physical optics: integrated modeling, phase retrieval, segmented systems, polynomials and fitting, sequential raytracing...
https://prysm.readthedocs.io/en/stable/
MIT License
269 stars 46 forks source link

Update io.py #31

Closed erik-bu closed 4 years ago

erik-bu commented 4 years ago

Adding unit support for height/phase unit of 'NanoMeters'. This is one of the unit options for Zygo data export.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.04%) to 80.273% when pulling 895219ca4fc750588b1ee47a05e299f805fe4fed on erik-bu:master into 20cea2faf827267f33a576eba2fb54e1b5dd2517 on brandondube:master.

brandondube commented 4 years ago

Thanks for the PR! Could you provide a sample datx file showing that it works? I understand IP ownership problems with that. If not, can you just show a file in HDF5Viewer highlighting the attribute? This is a really trivial addition but I still want to dot the is and cross the ts.

erik-bu commented 4 years ago

I am happy to contribute, even if it is just a tiny addition. I can't share a file, due to IP reasons. I've attached a screen cap of the unit output from h5py. I think that should suffice. Let me know if you need anything else. Thanks!

NanoMeters_screencap

brandondube commented 4 years ago

yes, that'll do. I made the merge, cheers!

brandondube commented 3 years ago

As a followup, this is now in a stable release, v0.19.1 -- see release notes

Happy Holidays!