Import/Export for Zemax Grid Phase and Sag ASCII Files

JakobSilbermann commented 3 years ago

Hello,

it would be grat to have such a feature in the io module. I already coded a bit but i am not such a good programmer and there are at some points some bugs. How can i contribute? I already read https://prysm.readthedocs.io/en/stable/contributing.html and forked prysm but i never did a project in github so far. So haw can i add my code?

All the best Jakob

brandondube commented 3 years ago

This would certainly be a good feature to add!

To add your code, please...

[x] fork prysm
[ ] commit any changes in your fork (io.py)
[ ] if you can, add a sample file, with all the same process as your other comment on #7
[ ] predicated on having a sample file, write at least one unit test. The minimum bar verifies that the code doesn't crash (say, tests/test_io.py#test_zemax_gridphase_parser_functional()). A nice test verifies something about the result is correct, say that the RMS and PV of the extracted data are as expected (pytest.approx is your friend here)

Once you do those things, open a PR (pull request tab on brandondube/prysm) and it can be reviewed for merge!

JakobSilbermann commented 3 years ago

Ok i am working on it just started to find my ways in in github and all the terminology :)

brandondube / prysm

Import/Export for Zemax Grid Phase and Sag ASCII Files #34