search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.65k stars 114 forks source link

Celluoid 0.16.1 has been yanked #122

Closed tmartin8080 closed 8 years ago

tmartin8080 commented 9 years ago

May need to update to version 0.17.0

https://rubygems.org/gems/celluloid/versions

derrek commented 9 years ago

:+1: just ran into this mess. Had to add celluloid fixed at 0.16.0 into the Gemfile to satisfy sucker_punch dependencies and bundle without error.

brandonhilkert commented 9 years ago

Unfortunately, this is a little more complicated, b/c the pools that were used were split out. I wish i could update it real quick, but it's going to take more refactoring to implement the new release. Sorry :/

brandonhilkert commented 9 years ago

It doesn't look yanked anymore, can you confirm there's still an issue. I can lock it at 0.16.0 if that would help now. Thoughts?

derrek commented 9 years ago

I think it's still yanked. If I go here: https://rubygems.org/gems/celluloid/versions i see

0.16.1 - August 8, 2015 (63.5 KB) yanked
brandonhilkert commented 9 years ago

@derrek I see, but 0.16.0 is still out. So if i lock to that, would that solve the problem for now? it's the using optimistic versioning so the trouble is when you already have 0.16.1 installed on your system.

brandonhilkert commented 9 years ago

Just released version 1.5.1 of Sucker Punch locked to the lower version. Please confirm if that fixed it for now.

re: https://github.com/brandonhilkert/sucker_punch/commit/579b5d9110334724ccd464d3a8ac794c9d36b1a6

derrek commented 9 years ago

Looks good :+1: