search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.65k stars 114 forks source link

Update to Celluloid 0.17 #126

Closed donaldpiret closed 8 years ago

donaldpiret commented 9 years ago

Not sure if this is 100% correct. Couldn't really figure out what the CellProxy was doing. Would appreciate if you could have a look.

brandonhilkert commented 9 years ago

Hey Donald! Thanks for the this. Give me a little bit to look over and understand what's going on with new Celluloid and I'll get back to you. Thanks again!

eileencodes commented 8 years ago

When you merge this, it needs to go to celluloid 0.17.2, there's apparently a memory leak in anything below 0.17.2 although the repo doesn't confirm this in the changelog. I read about it here https://github.com/mperham/sidekiq/issues/2582

brandonhilkert commented 8 years ago

I saw a similar Tweet from Mike yesterday. Thanks for the heads up!

_Build a Ruby Gem is available! http://brandonhilkert.com/books/build-a-ruby-gem/?utm_source=gmail-sig&utm_medium=email&utm_campaign=gmail_

http://brandonhilkert.com

On Fri, Oct 2, 2015 at 8:58 AM, Eileen M. Uchitelle < notifications@github.com> wrote:

When you merge this, it needs to go to celluloid 0.17.2, there's apparently a memory leak in anything below 0.17.2 although the repo doesn't confirm this in the changelog. I read about it here mperham/sidekiq#2582 https://github.com/mperham/sidekiq/issues/2582

— Reply to this email directly or view it on GitHub https://github.com/brandonhilkert/sucker_punch/pull/126#issuecomment-145014082 .

brandonhilkert commented 8 years ago

Release version 1.6.0 today as a result of your work. Thanks for the help here!