search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.65k stars 114 forks source link

Make ActiveJob::SuckerPunchAdapter compatible with v2 syntax #159

Closed dhh closed 8 years ago

dhh commented 8 years ago

With the syntax change, the Rails adapter is failing with: NoMethodError (undefined methodasync' for #ActiveJob::QueueAdapters::SuckerPunchAdapter::JobWrapper:0x007f8399ab82a8): `

It'd be great if we could fit a way to make that adapter still work even with v2. Seems a bit much to have a SuckerPunch2 adapter just for that.

Thoughts?

brandonhilkert commented 8 years ago

The last note under ActiveJob integration mentions the module you can drag in to make it work with 2.0.0.beta1.

I was planning to release 2.0.0 this week and subsequently submit a PR to rails for proper integration with the new version. I have all the Rails changes setup locally. Another benefit is the syntax for performing a job in the future is now native.

Will that timing work with the Rails 5 release?

dhh commented 8 years ago

Sweet. That'll work. We're probably going to do a beta2 next week. Then a rc1 shortly there after. Final release in February.

Thanks again for your great work on Sucker Punch!

On Sun, Jan 24, 2016 at 3:55 PM, Brandon Hilkert notifications@github.com wrote:

The last note under ActiveJob integration https://github.com/brandonhilkert/sucker_punch#active-job mentions the module you can drag in to make it work with 2.0.0.beta1.

I was planning to release 2.0.0 this week and subsequently submit a PR to rails for proper integration with the new version. I have all the Rails changes setup locally. Another benefit is the syntax for performing a job in the future is now native.

Will that timing work with the Rails 5 release?

— Reply to this email directly or view it on GitHub https://github.com/brandonhilkert/sucker_punch/issues/159#issuecomment-174306035 .

brandonhilkert commented 8 years ago

@dhh All good with this: https://github.com/rails/rails/pull/23284

dhh commented 8 years ago

👌

On Jan 27, 2016, at 21:35, Brandon Hilkert notifications@github.com wrote:

@dhh All good with this: rails/rails#23284

— Reply to this email directly or view it on GitHub.