search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.64k stars 114 forks source link

[skip ci] Remove extra blank from template using the generator #182

Closed goldenson closed 8 years ago

goldenson commented 8 years ago

This PR removes the extra blank of the template using the generator.

screen shot 2016-09-24 at 4 20 37 pm
goldenson commented 8 years ago

I wonder if we should make it inherit from ApplicationJob ?

Like from the Rails guide here

brandonhilkert commented 8 years ago

Sucker punch doesn't require Rails and should be able to be used in non-Rails projects.

On Saturday, September 24, 2016, Maxime Orefice notifications@github.com wrote:

I wonder if we should make it inherit from ApplicationJob ?

Like from the Rails guide here http://edgeguides.rubyonrails.org/active_job_basics.html#create-the-job

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/brandonhilkert/sucker_punch/pull/182#issuecomment-249386084, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtbFHsPWWmIib4nsCmlMq7Jv1WRJFmsks5qtYkdgaJpZM4KFvHw .

http://brandonhilkert.com