search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.64k stars 114 forks source link

Jobs getting killed #191

Closed solars closed 7 years ago

solars commented 7 years ago

Hi there,

I've got an application that updates data in the background via sucker punch.

Due to delays caused by a missing index I noticed that certain jobs did not complete - probably because they took too long.

I didn't find any details about how sucker_punch handles this, the apps are running under passenger. The shutdown_timeout is only used application shutdowns, right?

brandonhilkert commented 7 years ago

To be specific, shutdown_timeout is not used anywhere else in the code for any kind of execution timeout. I suppose there could be questions about how passenger would handle long-running threads like that. I'm not familiar with how it works to know if that could potentially be a problem. But there's nothing in SP that would cut it off intentionally.

solars commented 7 years ago

Thanks for the clarification! I thought so - trying to find out how passenger limits this.