search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.64k stars 114 forks source link

`~> 1.0.0` dependency on concurrent-ruby #219

Closed pitr-ch closed 6 years ago

pitr-ch commented 6 years ago

Hi @brandonhilkert, would you consider depending just on ~> 1.0 that way having sucker_punch will not prevent users getting 1.1.0 when it's released (there is currently pre1).

brandonhilkert commented 6 years ago

Sure. Want to add a PR?

On Tue, Aug 28, 2018 at 5:05 AM Chalupa Petr notifications@github.com wrote:

Hi @brandonhilkert https://github.com/brandonhilkert, would you consider depending just on ~> 1.0 that way having sucker_punch will not prevent users getting 1.1.0 when it's released (there is currently pre1).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brandonhilkert/sucker_punch/issues/219, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtbFL2kv5cHiCBWi0k7JmWUAqCdcfV4ks5uVQfqgaJpZM4WPNB5 .

--

http://brandonhilkert.com

pitr-ch commented 6 years ago

Thanks, sure, https://github.com/brandonhilkert/sucker_punch/pull/220