Test with Ruby 2.0-3.0, TruffleRuby, remove rbx-2

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.

MIT License

2.65k stars 114 forks source link

Test with Ruby 2.0-3.0, TruffleRuby, remove rbx-2 #237

Closed aried3r closed 3 years ago

aried3r commented 3 years ago

These are some opinionated changes, but I thought I'd start a discussion with this PR if necessary. I thought we might also set required_ruby_version in the .gemspec file, WDYT?

Edit: It seems Travis CI has been "disconnected" from GitHub, possibly due to inactivity. The current build is here: https://travis-ci.org/github/brandonhilkert/sucker_punch/builds/759174730 but maybe we can reactivate the build status for PRs?

brandonhilkert commented 3 years ago

I'm going to move the whole thing to GH actions. Travis seems like it's slowly going away.

aried3r commented 3 years ago

Travis seems like it's slowly going away.

It is, sort of. Until GH Actions are in place, wouldn't it still be a good idea to have all Rubies tested, given that v3 of this gem specifically added support for it? Since the PR is already there.

Edit: Nevermind. While I was typing this you opened #238. Awesome!