search

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.65k stars 114 forks source link

Support celluloid 0.16.0.pre #74

Closed prashantrajan closed 10 years ago

prashantrajan commented 10 years ago

Would it be possible to relax the celluloid dependency to support 0.16.0.pre ?

A bunch of gems now require celluloid ~> 0.16.0.pre and in a project that has gems that depend on sucker_punch it's a pain to update.

brandonhilkert commented 10 years ago

Which gems?

_The Build a Ruby Gem guide is available! http://brandonhilkert.com/books/build-a-ruby-gem/?utm_source=gmail-sig&utm_medium=email&utm_campaign=gem-config_

http://brandonhilkert.com

On Tue, Sep 2, 2014 at 1:42 PM, Prashant Nadarajan <notifications@github.com

wrote:

Would it be possible to relax the celluloid dependency to support 0.16.0.pre ?

A bunch of gems now require celluloid ~> 0.16.0.pre and in a project that has gems that depend on sucker_punch it's a pain to update.

— Reply to this email directly or view it on GitHub https://github.com/brandonhilkert/sucker_punch/issues/74.

prashantrajan commented 10 years ago

http://rubygems.org/gems/ridley for one

brandonhilkert commented 10 years ago

I'm not comfortable allowing accessible to a non-stable version of celluloid. If you want to make this work temporarily, suggestion would be to fork the gem and change the celluloid dependencies to match what you want.

Once it's stable, I'll look to change the version permanently after ensuring the pieces used in sucker punch still work as expected.

On Tuesday, September 2, 2014, Prashant Nadarajan notifications@github.com wrote:

http://rubygems.org/gems/ridley for one

— Reply to this email directly or view it on GitHub https://github.com/brandonhilkert/sucker_punch/issues/74#issuecomment-54210314 .

_The Build a Ruby Gem guide is available! http://brandonhilkert.com/books/build-a-ruby-gem/?utm_source=gmail-sig&utm_medium=email&utm_campaign=gem-config_

http://brandonhilkert.com

prashantrajan commented 10 years ago

Noted. Thanks for the reply

gretel commented 10 years ago 
Bundler could not find compatible versions for gem "celluloid":
  In Gemfile:
    sucker_punch (~> 1.0) ruby depends on
      celluloid (~> 0.14.1) ruby

    celluloid (0.16.0)

too bad i can't use sucker_punch in production for now :trollface:

brandonhilkert commented 10 years ago

@gretel Not sure why you're seeing that. Try bundle update sucker_punch. 0.14.1 was a dependency of an old version.

re: https://github.com/brandonhilkert/sucker_punch/blob/master/sucker_punch.gemspec#L25

alpinegizmo commented 10 years ago

I'm seeing this problem too. Given that we're no longer talking about a non-stable celluloid release, couldn't the dependency be updated to 0.16.0 ?

Bundler could not find compatible versions for gem "celluloid":
  In Gemfile:
    sucker_punch (~> 1.0) ruby depends on
      celluloid (~> 0.14.1) ruby

    guard-rspec (>= 0) ruby depends on
      guard (~> 2.1) ruby depends on
        listen (~> 2.7) ruby depends on
          celluloid (0.16.0)
brandonhilkert commented 10 years ago

version 1.2 released https://github.com/brandonhilkert/sucker_punch/blob/master/CHANGES.md#12

brandonhilkert commented 10 years ago

FYI - i had to back out of the update of Celluloid 0.16. It is not production-ready yet. With Sucker Punch in Rails, I have to be more careful about when new versions are released.

I have since added the branch celluloid-16, so use that for now until Celluloid 0.16 is production-ready.

brandonhilkert commented 9 years ago

master version 1.3.0 released with Celluloid version 0.16.0