brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.
MIT License
2.65k stars 114 forks source link

Proper way to use external exception management tool? #78

Closed mm53bar closed 9 years ago

mm53bar commented 9 years ago

I use rollbar.com as an external exception management tool. It isn't covered in your README, but it looks like the right way for me to send exceptions in my jobs to rollbar is to create a config/initializers/sucker_punch.rb file that contains:

SuckerPunch.exception_handler { |ex| Rollbar.report_exception(ex) }

Is that the correct way for me to add the exception handler in?

If that's the case then you should add that into your README. I'd be happy to submit a pull request to that effect if I've got the syntax correct.

brandonhilkert commented 9 years ago

Yeah, that should be it. A PR would be great!

On Saturday, October 4, 2014, Michael McClenaghan notifications@github.com wrote:

I use rollbar.com as an external exception management tool. It isn't covered in your README, but it looks like the right way for me to send exceptions in my jobs to rollbar is to create a config/initializers/sucker_punch.rb file that contains:

SuckerPunch.exception_handler { |ex| Rollbar.report_exception(ex) }

Is that the correct way for me to add the exception handler in?

If that's the case then you should add that into your README. I'd be happy to submit a pull request to that effect if I've got the syntax correct.

— Reply to this email directly or view it on GitHub https://github.com/brandonhilkert/sucker_punch/issues/78.


_The Build a Ruby Gem guide is available! http://brandonhilkert.com/books/build-a-ruby-gem/?utm_source=gmail-sig&utm_medium=email&utm_campaign=gem-config_

http://brandonhilkert.com

merqlove commented 9 years ago

Right, for Airbrake:

SuckerPunch.exception_handler { |ex| Airbrake.notify(ex) }

openface commented 9 years ago

PR #109