require sucker_punch before monkey patch

brandonhilkert / sucker_punch

Sucker Punch is a Ruby asynchronous processing library using concurrent-ruby, heavily influenced by Sidekiq and girl_friday.

MIT License

2.65k stars 114 forks source link

Closed seuros closed 9 years ago

brandonhilkert commented 9 years ago

That's probably safer. You think this is better than the new PR i opened of requiring 'sucker_punch' in the Rails test adapter?

seuros commented 9 years ago

Yes, because it will avoid similar problem for other projects.

brandonhilkert commented 9 years ago

OK. If I bump the version, would Rails still need a PR to update SP?

seuros commented 9 years ago

I will restart the tests when you release.

brandonhilkert commented 9 years ago

Released 1.3.1

seuros commented 9 years ago

The build is :green_heart: now. Thank you.