search

brandonkal / pulumi-command

A Pulumi resource provider for running commands
Apache License 2.0
15 stars 1 forks source link

Add python and go support to pulumi-command #13

Closed gordonbondon closed 3 years ago

gordonbondon commented 3 years ago

Hi there! Thank you for implementing this provider!

I've found it very useful and wanted to add simple support for Go and Python, but got carried away a bit 😄

PR looks huge, but most lines are just removed yarn locks and generated code. I've split it into commits for easier review:

  1. 87a99a0 (#13) - Updated provider code to latest Pulumi SDK and structured it according to official providers like pulumi-kubernetes
  2. f860db3 (#13), 251aaad (#13) - generated Go and Python sdk using new provider codegen, nothing to see here.
  3. 4a102e3 (#13), 43e6fce (#13) - updated existing Node and Dotnet code to work with new provider binary. Changes should be backward compatible.
  4. 20b8e59 (#13), bd8f8bb (#13) - added integration tests for all 4 runtimes using Automation API. Tests cover that create, diff, update, delete commands are properly passed to the provider. Looks like Drone CI was not actually used, so I've replaced it with GitHub actions.

Related #1

brandonkal commented 3 years ago

Thank you for taking this on. Looks good.

gordonbondon commented 3 years ago

@brandonkal thank you for merging!

Would you be interested in hosting provider binaries in this repo releases and also releasing updated sdks? I can submit a PR with Github workflow that should take care of releasing binaries, npm, pypi and nuget, provided you setup required secrets.

brandonkal commented 3 years ago

If it is hosted with GitHub.