brandonmpetty / Doxa

A Local Adaptive Thresholding framework for image binarization written in C++, with JS and Python bindings. Implementing: Otsu, Bernsen, Niblack, Sauvola, Wolf, Gatos, NICK, Su, T.R. Singh, WAN, ISauvola, Bataineh, Chan and Shafait.
https://brandonmpetty.github.io/Doxa/WebAssembly
Creative Commons Zero v1.0 Universal
167 stars 37 forks source link

version of c++ #1

Closed vitiennam closed 6 years ago

vitiennam commented 6 years ago

HI,

I try to run BinaryImageConverter.cpp on Clion but it have trouble: Binarization/Image.hpp:127:47: error: expected ‘,’ or ‘...’ before ‘default’ inline Pixel32 Pixel(int x, int y, Pixel32 default) const { return (x < 0 || x >= width || y < 0 || y >= height) ? default: Pixel(x, y); }

Binarization/Image.hpp:127:119: error: expected ‘:’ before ‘default’ Binarization/Image.hpp:127:119: error: expected primary-expression before ‘default’ Binarization/Image.hpp:127:119: error: expected ‘;’ before ‘default’ Binarization/Image.hpp:127:119: error: case label not within a switch statement

I am using c++ 11: set(CMAKE_CXX_STANDARD 11)

Thanks

brandonmpetty commented 6 years ago

Sorry for the delayed response. I just made a pretty large push today that included an update to all of the projects to leverage C++17 language features. Hopefully this will save you from having to make any manual changes to VS. Let me know if you run into any issues. Some projects are leveraging nested namespaces and the new file system api.

brandonmpetty commented 6 years ago

I had missed the fact that you were not using MSVC. While my earlier comment was correct, you will need C++17 support, the issue you described had nothing to do with it. This issue should be resolved with my latest commit. While I had originally developed this code-base on my MacBook using Clang, I had moved away from it in favor of the Visual Studio environment... and in the process sadly got tied into their Unit Testing framework along the way. I am trying to upgrade clang on my mac to a version that supports C++17, once I do that and verify everything is running correctly I will close this issue. Thank you for bringing it to my attention @kimchicanh.

brandonmpetty commented 6 years ago

All demo's can now be built with Clang (7.0) in addition to Microsoft's VS C++ compiler (15.4).