search

brandonmpetty / Doxa

A Local Adaptive Thresholding framework for image binarization written in C++, with JS and Python bindings. Implementing: Otsu, Bernsen, Niblack, Sauvola, Wolf, Gatos, NICK, Su, T.R. Singh, WAN, ISauvola, Bataineh, Chan and Shafait.
https://brandonmpetty.github.io/Doxa/WebAssembly
Creative Commons Zero v1.0 Universal
167 stars 37 forks source link

Fix missing Template and include Palette.hpp #4

Closed VisualFox closed 5 years ago

VisualFox commented 5 years ago

Thank you for your work on Doxa, I really appreciate it! I am quite excited by Doxa2.

Unfortunately I was not able to compile Doxa2 with clang (clang6) on Ubuntu. It seems to me that GlobalThreshold (in Algorithm.hpp) was missing some template parameter. Now I am just starting to learn c++ so I may have missed something really obvious.

I also included the Palette.hpp header in Algorithm.hpp but that maybe unnecessary as Palette.hpp maybe include earlier one (I needed it in order to debug the template parameter issue).

Thank you!

brandonmpetty commented 5 years ago

Thanks for the contribution, @VisualFox. I am glad to get the feedback about the Doxa2 updates. I may have rushed it a little bit, so thanks for catching and fixing the Clang error.