search

brandonp2412 / Flexify

Track your gym progress - Completely offline
MIT License
120 stars 9 forks source link

[bug] Images keep disappearing (but are still there, hidden) #92

Open Crazy-Unicooorn opened 1 month ago

Crazy-Unicooorn commented 1 month ago

One issue that I found some time ago now and is still present under version 1.1.75, is the images disappearing. They are still there, and to make one appear again, you have to simulate updating the image, and just hitting "save" does the trick.

Video: https://github.com/user-attachments/assets/0f366268-39c2-4390-8c5c-b753e652f7a2

I don't know how they disappear though… so I can't say how to replicate. However, it seems that this is an issue "per exercice", meaning that each exercice is affected independently.

On… Galaxy S20 FE 5G Android 13 One UI 5.1

brandonp2412 commented 1 month ago

Yep I need to make it more of a guarantee the images are always the same. Its stored against each individual set when it should probably be stored in a separate table with a join. A lot of the data is De-normalized by default because I didn't have experience doing Drift joins but I've learned a lot since then.

brandonp2412 commented 1 month ago

This happens when you create gym sets from the Plans page, I forgot to retrieve the image there

Crazy-Unicooorn commented 1 month ago

Hey @brandonp2412 , unfortuately this is still happening in version 1.1.78 😔

brandonp2412 commented 1 month ago

Fuck it i'll fix it properly like i said i was going to in the beginning. This is what i get for being lazy. Maybe we will get performance benefits anyway from splitting out many of these fields in the gym sets table

Crazy-Unicooorn commented 1 month ago

Lol, no pressure bro! It's not like it's a critical bug 😆 Take your time, the app is already pretty awesome and useful 😁