brandonroberts / vladivostok-sample

1 stars 0 forks source link

CrisisCenter bug: CanDeactivate not used as the generic interface it is #10

Closed wardbell closed 8 years ago

wardbell commented 8 years ago

One of the problems of this implementation is we (maybe just "I") not getting intellisense.

Therefore can't see (and in-browser transpiler not telling us) that this is an error

export class CanDeactivateCrisisDetail implements CanDeactivate {

and should be

export class CanDeactivateCrisisDetail implements CanDeactivate<CrisisDetailComponent> {
brandonroberts commented 8 years ago

Closed via 00a10648a55d93fce5b6597d84f0f66dd4a87b4e