search

brandonsato / cbbpoll

This is the app for managing the /r/CollegeBasketball user poll
4 stars 5 forks source link

Adds command to auto post results to reddit #53

Closed jdharms closed 9 years ago

jdharms commented 9 years ago

Adds link to reddit post to results table, adds migration for redditUrl to poll, moves "copy reddit markup" to separate template to be used by the automatic poster.

brandonsato commented 9 years ago

Haven't had a chance to go through everything, but just at first glance a couple of things.

reddit_results_text.html should probably be reddit_results_text.md since it's purely markdown + jinja2.

Also, the post text should be a template, reddit_results_post.md or something. Include reddit_results_text.md and then add the link afterwards so you can rely on jinja to generate the entire thing. Cleans things up and allows for easier updates you may want to make to the template. Maybe rename reddit_results_text to reddit_results_table for distinction between the post template and just the table.

jdharms commented 9 years ago

Thanks, I'll address this tonight. Please feel free to leave any more feedback.