brandonshawfhl / Quiz-Maker

0 stars 0 forks source link

bad naming #2

Closed incredibleLeitman closed 10 months ago

incredibleLeitman commented 10 months ago

https://github.com/brandonshawfhl/Quiz-Maker/blob/416f68249cd349a67cf7cf2c22f6b49941546230/ConsoleApp3/UserInterface.cs#L73 https://github.com/brandonshawfhl/Quiz-Maker/blob/416f68249cd349a67cf7cf2c22f6b49941546230/ConsoleApp3/UserInterface.cs#L88

"IsSomethingSomething" is a good function name when checking if specific flags or variables are set 👍 But in this case you are referring to get user input, which is why you should stick to your consistent naming that starts with "PromptFor...".

(also think about renaming "GetMoreQuestions" 👆 )

But going further, I think you don't want to specifically ask for all options separately like

Instead you could create one UI method that ask for the mode (which could be made of enums like TYPE_PLAY, TYPECREATE, TYPE...) and handle the logic separately