search

brandonshin / slackbot-workout

A fun hack that gets Slackbot to force your teammates to work out!
MIT License
563 stars 128 forks source link

Avoids duplicates when the configured number of people to call out is… #29

Open timmytofu opened 9 years ago

timmytofu commented 9 years ago

… greater than the number active in the channel

traceyvanp commented 9 years ago

Hi! After I edited the slackbotExercise file to incorporate your pull request of avoiding duplicates, I'm getting an "Insecure Platform Warning" (InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail.) The workout was working before, any ideas what could cause this error? It runs fine up to the point of announcing the next lottery, and then never announces. Also, could I add another exercise "sit-ups", just by editing config.json (default.json) like this: { "id": 4, "name": "calf raises", "minReps": 20, "maxReps": 30, "units": "rep" }, { "id": 5, "name": "sit-ups", "minReps": 30, "maxReps": 50, "units": "rep" }

timmytofu commented 9 years ago

Not sure, I was seeing that warning all along…

traceyvanp commented 9 years ago

I ran the code using a later version of Python (2.5 to 2.9) and it works with no Insecure Platform Warning error!

alexkolson commented 9 years ago

@timmytofu Does this actually work? I merged it into my fork downstream and I get an index out of range error.

timmytofu commented 9 years ago

Indeed you're right. I've updated it to use a for each loop, though I feel like there was a reason I didn't do that in the first place. Honestly I haven't done python in ten years and didn't do much then, so all of this is probably not the best.

alexkolson commented 9 years ago

@timmytofu I'm no python guru myself, and I really just asked to make sure I wasn't crazy because I think this feature is awesome and I want to pull it into my downstream fork. :+1: