Closed hntd187 closed 8 years ago
No worries, thanks for your contribution! Just a minor comment w/ the test framework usage
Bah okay @brandtg why don't we just turn this off? I think jfreechart does an X11 call no matter what. I suppose these tools should just exist as user tools and not something we can throw in the CI loop.
@hntd187 Fair enough, SGTM. Regarding testing though, I do think we could benefit from something that generates some series with known trend + seasonal and noise / anomalies, then see if we can decompose and get something similar w/in error bounds. Something similar to this but maybe less simplistic: https://github.com/brandtg/stl-java/blob/master/src/test/java/com/github/brandtg/TestStlDecomposition.java#L42
@brandtg ballin out of control, that should let us continue to test this and keep travis happy. Let's open a new issue for the other suggestion you made.
SGTM
StlPlotter now saves the file instead of displaying it to the screen for travisCI. Also enabled the test for the plotter and added some new tests to make sure the plot is generated. This should fix #4 , better late than never right? :zzz: :zzz: