Closed kytrinyx closed 5 years ago
Hey there, just checking in quickly. If there's anything I can do to help clarify any of the changes here, let me know. I know this part of the code is really tricky!
Sorry @kytrinyx! I was on vacation for a week and am still unwinding my inbox. Thanks a lot for the incredible effort in digging into this venerable bug!
A+++ commit hygiene / comments / code / tests — you're making this really easy for me.
Released as 0.20.4.
I made three separate commits in order to make this easier to review.
The first commit is just a pure re-arrangement, in order to make it easier to understand exactly what changed in the second commit.
The second commit adds a failing test for the
oneOf
scenario reported in #100. It fails with the following:It also adds the fix.
Given that the edge case in #100 describes
oneOf
with a reference to an external schema, I also figured we should test it with a reference to a local schema. ✨It failed ✨.The third commit adds a failing test for the "local schema" variant of
oneOf
, which gives the following error:It then fixes it.
Closes #100.