search

brandur / json_schema

A JSON Schema V4 and Hyperschema V4 parser and validator.
MIT License
230 stars 45 forks source link

Make `type` optional on errors #17

Closed brandur closed 9 years ago

brandur commented 10 years ago

This will allow us to maintain backward compatibility with the API for a bit longer, so as not to necessitate a major version bump.

isaacseymour commented 10 years ago

Are the error objects part of the API? I'd argue they're internal, so anyone instantiating them directly is doing a dirty hack and deserves what they get. Also having the type non-optional makes sure every error returned by the library includes one (or AttributeErrors), so I'd argue for at least some kind of warning if an error gets instantiated without a type.

isaacseymour commented 10 years ago

@brandur ping!

barisbalic commented 9 years ago

Hey @brandur we're looking forward to using json_schema, but we're dependent on the changes/version bump from #15, we can roll onto our own branch, but it would be much nicer to continue using your published version.

brandur commented 9 years ago

@isaacseymour @barisbalic My sincere apologies guys. Unfortunately, I let my mountain of GH notifications get the better of me. I'm going to close this and bump the version.

@isaacseymour That's a tough one. I usually err on the side of being conservative, but I think in this case you're right. Not to mention that we probably don't have enough actual consumers of this gem that it's likely to cause widespread problems.

isaacseymour commented 9 years ago

@brandur know how you feel! Thanks for pushing it.