search

brandur / json_schema

A JSON Schema V4 and Hyperschema V4 parser and validator.
MIT License
230 stars 45 forks source link

Method params error in ruby 1.9 #43

Closed schorsch closed 8 years ago

schorsch commented 8 years ago

i know its an older ruby version but it seems like a quick fix:

the method signature here: https://github.com/brandur/json_schema/blob/master/lib/json_schema/schema_error.rb#L23

should be changed from "data: nil" to "data=nil"

brandur commented 8 years ago

I guess it's technically possible to change because that's mostly an internal-only API.

The only thing is that Ruby 1.9 has been EOL'ed for almost a year now and we're going to have to say goodbye to it eventually. It's not a great idea to be using it now because it's not going to get security patches and the like backported. I'm guessing that getting off of Ruby 1.9 is particularly hard for your setup?

schorsch commented 8 years ago

I think i can get around 1.9, its just a travis.yml still testing with this ruby version.

brandur commented 8 years ago

@schorsch Ah! Good to know. Alright, I'm going to close this issue out for now then, but lemme know if anything else comes up.