support additionalItems as a schema for array validation

brandur / json_schema

A JSON Schema V4 and Hyperschema V4 parser and validator.

MIT License

230 stars 45 forks source link

support additionalItems as a schema for array validation #64

Closed jkamerer closed 8 years ago

brandur commented 8 years ago

@jkamerer Wow, amazing work here! Thanks a lot for adding the comprehensive test suite in particular. I've added a few minor comments above, but once they're fixed this is good to come in.

I'm not sure how I missed the schema version of additionalItems the first time around. Crazy!

jkamerer commented 8 years ago

@brandur thanks for checking out the pull request so quickly. I have this monkey patched locally but will be nice to update the gem and get rid of the monkey patch. This use of additionalItems in this way is possibly not that common, but I need it for a schema definition I'm using (obviously). At least your parser was allowing a Hash, so you noticed it at some level, just didn't follow through all the way implement it!

brandur commented 8 years ago

@jkamerer Thanks for the fixes!

Merged and released as 0.13.0.