search

branelab / SimMEEG

Software for simulating MEG and EEG event-related responses. functional connectivity, and phase-amplitude coupling
Other
3 stars 5 forks source link

Check for required Matlab toolboxes #5

Open rcassani opened 2 years ago

rcassani commented 2 years ago

  1. Add a check for the required Matlab toolboxes.

  2. Let Brainstorm to handle FieldTrip defaults

  3. Bugfix at creating paths in Unix-like OS

ftadel commented 2 years ago

@branelab You should not add or remove folders from the FieldTrip path, you should let Brainstorm and/or FieldTrip manage their own paths. When installing FieldTrip, one should NOT add all the subfolders to the Matlab path. Only the top folder of FieldTrip can be added to the path (exactly like Brainstorm). Then FieldTrip adds to the path the subfolders that are needed only, depending on the Matlab version and the additional toolboxes installed on the computer.

@rcassani You may remove all these lines dealing with the FieldTrip path management: these folders should not be in there in the first place. Trying to manage manually the paths of FieldTrip and Brainstorm can lead to bugs that are difficult to understand, even by the developers.

rcassani commented 2 years ago

@ftadel, thanks for the insight. The handling of the FT path is removed. However a new trouble is found as there is dependency for FT functions in ft_plotting, and it's loaded by Brainstorm.

ftadel commented 2 years ago

However a new trouble is found as there is dependency for FT functions in ft_plotting, and it's loaded by Brainstorm.

Can you give some more details about this issue?

rcassani closed this 18 hours ago

Dead end?

rcassani commented 2 years ago

Can you give some more details about this issue?

Sorry for the false alarm, it was my messy path

Dead end?

Not really, I think the FT path handling can be solved like this: 5ed7b77e92693cf485498d988d74936dc8cc5df4