Add JSO wrapper for MarkerClustererPlus

branflake2267 / GWT-Maps-V3-Api

GWT Maps V3 Javascript Bindings

Other

144 stars 113 forks source link

Add JSO wrapper for MarkerClustererPlus #165

Closed tvernum closed 11 years ago

tvernum commented 11 years ago

This is a JSO wrapper around MarkerClustererPlus

It (mostly) only implements the parts of the API that I needed. e.g. I haven't done anything with events.
It's numbered to match the version of MCP that it builds against, rather than the version of gwt-maps
It's currently dependant on gwt-maps 3.9-b17 because that's what my project is using.

I'm happy to rework things if needed, just let me know.

branflake2267 commented 11 years ago

Weird my comments didn't comment on the line, or something changed hm.

branflake2267 commented 11 years ago

Awesome job! I made a few nits.

newInstance
format with 2 spaces or consistent with the other modules.
no test cases yet, but that would be fine with me to start, to get this going since its a utility.
I can change the pom some once it gets integrated and test it before release. I think some of the stuff might be inherited by parent.

Overall excellent job!

twistedpair commented 11 years ago

Just curious, how will this reconcile with the Gmaps version tracking against this project's versions? Release 3.10 will be Gmaps 3.10, not 3.9. Can we assume the Gmaps API should be backwards compatible?

branflake2267 commented 11 years ago

Nice work. Would you consider that ready.

Just a note, I merged my latest pom changes. This will conflict with your slightly. Sorry about that.

tvernum commented 11 years ago

Yes, I consider it ready - if we've settled on what to do with the version numbering.

branflake2267 commented 11 years ago

Could you merge it with the latest on master, resolve the conflict. I can take over on the version. I think I'll add -build-1 so that way the version that you gave I am guessing stands for the utility javascript version.

branflake2267 commented 11 years ago

unless you want to add -build-1-SNAPSHOT :)

tvernum commented 11 years ago

I think it's up to date now (sorry, I was working on other things for the last few days).

The merge with master didn't create any genuine conflicts, although there's probably some POM cleanup work to do.

branflake2267 commented 11 years ago

Good job. I'll merge and work on the pom in the next few days.