search

branflake2267 / GWT-Maps-V3-Api

GWT Maps V3 Javascript Bindings
Other
144 stars 113 forks source link

problems using set and get key-value pair of MVCObject #220

Open F43RY opened 10 years ago

F43RY commented 10 years ago

Hi, I've a problem trying to set a String value in polygons, circles and Objects extending MVCObject. I'd like to use polygon.set("myVar", "myValue"); or polygon.set("myVar", myNumber); and String myString = polygon.get("myVar); or Number myNumber = polygon.get("myVar"); but I only can use polygon.set("myVar", otherPolygon); and Polygon p = polygon.get("myVar"); this has no sense for me because I'd generate a hyerarchy of nested polygons but I cannot set a simple variable in none of them. I tried to use polygon.setValues(HashMap<String, String> map), but the getter method doesn't get any value.

F43RY commented 9 years ago

The code at the link below fix the issue: https://github.com/branflake2267/GWT-Maps-V3-Api/pull/188#issue-17804894 Is it possible ti merge the code in the master?

This is the main side of the comment: The signature of set(String, T) should probably be changed to set(String, Object) The signature of T get(String) should maybe be something like public final native U get(String), but I'll admit my grasp of generics is not 100% and I'm not so confident on this one. setValues(HashMap<String,String>) should probably become setValues(Map<String,?>).