Open branlwyd opened 11 years ago
9470ecadddef3515293f6e4ddccf25ab6beac7c7 handles the Operand refactorings.
99dc35871f0f8cf2ba976ab25ef13ef057d3e0f1 handles the value formatting refactor.
Renaming this since there is only one refactor left, and it's pretty big.
Refactor99dc35871f0f8cf2ba976ab25ef13ef057d3e0f1DebuggerFrame
,InstructionDecoder
,Operand
value formatting to use a newValueFormatter
interface rather than using parameters to specify hex or dec. This would add flexibility if we wanted to add different numeric formats later, or if we add another debugger UI.The9470ecadddef3515293f6e4ddccf25ab6beac7c7*Operand
classes in cc.bran.bdcpu16.codegen are only ever intended to be used byOperand
. Move these classes to be private internal classes toOperand
.Refactor9470ecadddef3515293f6e4ddccf25ab6beac7c7int Operand.wordsUsed()
intoboolean usesWord()
. Every operand uses 0 or 1 words, so this is still sufficiently expressive; and many places in code make the assumption that every operand will consume 0 or 1 words, so making this change will cause the interface to match the existing assumptions.