brannondorsey / PassGAN

A Deep Learning Approach for Password Guessing (https://arxiv.org/abs/1709.00440)
MIT License
1.78k stars 362 forks source link

i found many backticks in password simple,is it right? #6

Open Explorer1092 opened 6 years ago

Explorer1092 commented 6 years ago

root@07d198dcd43f:/notebooks# tail /mnt/passgan/samples/samples_172900.txt

Baugedd*76
ashas#1```
r.macj````
AvirTAbN``
dice@35```
Salderr65`
Ml4pann```
Ep044j8```
s?j009````
koph@9306`
brannondorsey commented 6 years ago

Yes, backticks are used to pad passwords to a fixed length (10 chars). Replace them with null once generated :+1:

brannondorsey commented 6 years ago

You found them in all generated passwords with length < 10 correct?

Explorer1092 commented 6 years ago

yes,length < 10。 Should I replace these backticks by myself?

brannondorsey commented 6 years ago

Unfortunately, yes. I didn't realize I left the backticks in there :fearful:. Away from my dev machine until next week, but I'll update the repo to fix this then. Until then, something like this should work:

# save this as remove-backticks.py
with open('samples.txt', 'r') as f:
    for line in f:
        print(line.replace('`', ''))
# run it like this
python remove-backticks.py > cleaned-samples.txt
brannondorsey commented 6 years ago

Actually, ya know what, this shouldn't even be happening. Not sure what is up. I'll take a look next week, thanks!

tjw960414 commented 6 years ago

您好,我在运行train.py文件时显示错误output-o需要参数,可是我不知道在哪加,请您解答感谢

brannondorsey commented 6 years ago

@tjw960414, are you referencing this issue or do you have a new question? If this is unrelated would you mind opening a new issue and providing more information about your problem?

Thanks.