search

brantje / nextnote

A full Evernote / OneNote style WYSIWYG note editor for Nextcloud / ownCloud. Join our telegram at: https://t.me/NextNote
GNU Affero General Public License v3.0
163 stars 19 forks source link

Grouping is buggy #22

Closed enoch85 closed 6 years ago

enoch85 commented 7 years ago

Here's a video.

Log 

Error PHP Undefined variable: deletedSql at /var/www/nextcloud/apps/ownnote/lib/Db/OwnNoteMapper.php#59 2017-07-08T14:32:49+0200

Complete log

  1. When editing a note then pressing in the groups sidebar, nothing happens. (The current note should be saved and the view should change to the Group or All view) 2. When editing a groped note, the name of the note in another group is also changed Seems fixed 3. The "All" view doesn't show all notes. Seems fixed. 4. New groups aren't saved under certain circumstances. I.e when creating a new note, add a new group, and hit save = the note ends up in "All" and group isn't saved Seems fixed
  2. Groups can't be deleted
  3. Changing name of a group results in a blank name. Also the CSS is wrong.
enoch85 commented 7 years ago

In the lastes version (when it's called NextNotes)

Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'UPDATE `oc_ownnote` SET `name` = ?,`grouping` = ?,`mtime` = ?,`deleted` = ?,`uid` = ?,`note` = ? WHERE `id` = ?' with params ["Test1", "", 1499531501, null, "ncadmin", "", 1]: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'deleted' cannot be null
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php - line 128: Doctrine\DBAL\Driver\AbstractMySQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException))
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Statement.php - line 177: Doctrine\DBAL\DBALException driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOMySql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'UPDATE `oc_ownn...', Array)
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 247: Doctrine\DBAL\Statement->execute()
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 187: OCP\AppFramework\Db\Mapper->execute('UPDATE `*PREFIX...', Array)
/var/www/nextcloud/apps/nextnote/lib/Db/NextNoteMapper.php - line 156: OCP\AppFramework\Db\Mapper->update(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/lib/Service/NextNoteService.php - line 121: OCA\NextNote\Db\NextNoteMapper->updateNote(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/controller/nextnoteapicontroller.php - line 118: OCA\NextNote\Service\NextNoteService->update(Object(OCA\NextNote\Db\NextNote))
[internal function] OCA\NextNote\Controller\NextNoteApiController->update(1, 'Test1', '', '', NULL)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 160: call_user_func_array(Array, Array)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 90: OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/App.php - line 114: OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47: OC\AppFramework\App main('OCA\\NextNote\\Co...', 'update', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
[internal function] OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)
/var/www/nextcloud/lib/private/Route/Router.php - line 299: call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)
/var/www/nextcloud/lib/base.php - line 1000: OC\Route\Router->match('/apps/nextnote/...')
/var/www/nextcloud/index.php - line 40: OC handleRequest()
{main}

vsprintf(): Too few arguments at /var/www/nextcloud/lib/private/legacy/l10n/string.php#72 | 2017-07-08T18:28:17+0200
Error | index | RuntimeException: image not found: image:app.svg webroot: serverroot:/var/www/nextcloud/var/www/nextcloud/apps/ownnote/lib/AppInfo/Application.php - line 110: OC\URLGenerator->imagePath('nextnote', 'app.svg')/var/www/nextcloud/lib/private/NavigationManager.php - line 108: OCA\NextNote\AppInfo\Application->OCA\NextNote\AppInfo\{closure}()/var/www/nextcloud/lib/private/legacy/app.php - line 645: OC\NavigationManager->getAll()/var/www/nextcloud/lib/private/TemplateLayout.php - line 80: OC_App getNavigation()/var/www/nextcloud/lib/private/legacy/template.php - line 205: OC\TemplateLayout->__construct('user', 'files')/var/www/nextcloud/lib/public/AppFramework/Http/TemplateResponse.php - line 157: OC_Template->fetchPage()/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 113: OCP\AppFramework\Http\TemplateResponse->render()/var/www/nextcloud/lib/private/AppFramework/App.php - line 114: OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files\Controller\ViewController), 'index')/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47: OC\AppFramework\App main('ViewController', 'index', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)[internal function] OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)/var/www/nextcloud/lib/private/Route/Router.php - line 299: call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)/var/www/nextcloud/lib/base.php - line 1000: OC\Route\Router->match('/apps/files/')/var/www/nextcloud/index.php - line 40: OC handleRequest(){main}

1
--
RuntimeException: image not found: image:app.svg webroot: serverroot:/var/www/nextcloud/var/www/nextcloud/apps/ownnote/lib/AppInfo/Application.php - line 110: OC\URLGenerator->imagePath('nextnote', 'app.svg')/var/www/nextcloud/lib/private/NavigationManager.php - line 108: OCA\NextNote\AppInfo\Application->OCA\NextNote\AppInfo\{closure}()/var/www/nextcloud/lib/private/legacy/app.php - line 645: OC\NavigationManager->getAll()/var/www/nextcloud/lib/private/TemplateLayout.php - line 80: OC_App getNavigation()/var/www/nextcloud/lib/private/legacy/template.php - line 205: OC\TemplateLayout->__construct('user', 'files')/var/www/nextcloud/lib/public/AppFramework/Http/TemplateResponse.php - line 157: OC_Template->fetchPage()/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 113: OCP\AppFramework\Http\TemplateResponse->render()/var/www/nextcloud/lib/private/AppFramework/App.php - line 114: OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files\Controller\ViewController), 'index')/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47: OC\AppFramework\App main('ViewController', 'index', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)[internal function] OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)/var/www/nextcloud/lib/private/Route/Router.php - line 299: call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)/var/www/nextcloud/lib/base.php - line 1000: OC\Route\Router->match('/apps/files/')/var/www/nextcloud/index.php - line 40: OC handleRequest(){main}

cc @brantje

brantje commented 7 years ago

^_ At what action does this happen?

enoch85 commented 7 years ago

At what action does this happen?

  1. Create a new note
  2. Save it
  3. Reload
  4. Go to the same note
  5. Put it in a group
Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'UPDATE `oc_ownnote` SET `name` = ?,`grouping` = ?,`mtime` = ?,`deleted` = ?,`uid` = ?,`note` = ? WHERE `id` = ?' with params ["wvqev", "", 1499533741, null, "ncadmin", "", 5]: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'deleted' cannot be null
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php - line 128: Doctrine\DBAL\Driver\AbstractMySQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException))
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Statement.php - line 177: Doctrine\DBAL\DBALException driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOMySql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'UPDATE `oc_ownn...', Array)
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 247: Doctrine\DBAL\Statement->execute()
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 187: OCP\AppFramework\Db\Mapper->execute('UPDATE `*PREFIX...', Array)
/var/www/nextcloud/apps/nextnote/lib/Db/NextNoteMapper.php - line 156: OCP\AppFramework\Db\Mapper->update(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/lib/Service/NextNoteService.php - line 121: OCA\NextNote\Db\NextNoteMapper->updateNote(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/controller/nextnoteapicontroller.php - line 118: OCA\NextNote\Service\NextNoteService->update(Object(OCA\NextNote\Db\NextNote))
[internal function] OCA\NextNote\Controller\NextNoteApiController->update(5, 'wvqev', '', '', NULL)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 160: call_user_func_array(Array, Array)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 90: OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/App.php - line 114: OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47: OC\AppFramework\App main('OCA\\NextNote\\Co...', 'update', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
[internal function] OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)
/var/www/nextcloud/lib/private/Route/Router.php - line 299: call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)
/var/www/nextcloud/lib/base.php - line 1000: OC\Route\Router->match('/apps/nextnote/...')
/var/www/nextcloud/index.php - line 40: OC handleRequest()
{main}
enoch85 commented 7 years ago

3. Error when renaming + CSS

A minor design fix when renaming: http://i.imgur.com/cIEgEhX.png

Changing name results in a blank name and when reloading they are back with their old name.

enoch85 commented 7 years ago

1. When editing a note then pressing in the groups sidebar, nothing happens.

https://cloud.techandme.se/s/To9F2ODRlwzMZqp

brantje commented 7 years ago

Renaming groups doesn't work atm, see #17

brantje commented 7 years ago

Fixed 2. Groups not saved in new note.

enoch85 commented 7 years ago

@brantje 2 isn't completley fixed:

Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'UPDATE `oc_ownnote` SET `name` = ?,`grouping` = ?,`mtime` = ?,`deleted` = ?,`uid` = ?,`note` = ? WHERE `id` = ?' with params ["testasr_ny_grupp", "testar_skapa_ny", 1499537337, null, "ncadmin", "", 11]: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'deleted' cannot be null
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php - line 128: Doctrine\DBAL\Driver\AbstractMySQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException))
/var/www/nextcloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Statement.php - line 177: Doctrine\DBAL\DBALException driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOMySql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'UPDATE `oc_ownn...', Array)
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 247: Doctrine\DBAL\Statement->execute()
/var/www/nextcloud/lib/public/AppFramework/Db/Mapper.php - line 187: OCP\AppFramework\Db\Mapper->execute('UPDATE `*PREFIX...', Array)
/var/www/nextcloud/apps/nextnote/lib/Db/NextNoteMapper.php - line 156: OCP\AppFramework\Db\Mapper->update(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/lib/Service/NextNoteService.php - line 121: OCA\NextNote\Db\NextNoteMapper->updateNote(Object(OCA\NextNote\Db\NextNote))
/var/www/nextcloud/apps/nextnote/controller/nextnoteapicontroller.php - line 118: OCA\NextNote\Service\NextNoteService->update(Object(OCA\NextNote\Db\NextNote))
[internal function] OCA\NextNote\Controller\NextNoteApiController->update(11, 'testasr_ny_grup...', 'testar_skapa_ny', '', NULL)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 160: call_user_func_array(Array, Array)
/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 90: OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/App.php - line 114: OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\NextNote\Controller\NextNoteApiController), 'update')
/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47: OC\AppFramework\App main('OCA\\NextNote\\Co...', 'update', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
[internal function] OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)
/var/www/nextcloud/lib/private/Route/Router.php - line 299: call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)
/var/www/nextcloud/lib/base.php - line 1000: OC\Route\Router->match('/apps/nextnote/...')
/var/www/nextcloud/index.php - line 40: OC handleRequest()
{main}

Also, the note itself (content isn't saved)

brantje commented 7 years ago

@enoch85 When does this happen? Edit or new note?

enoch85 commented 7 years ago

New note.

enoch85 commented 6 years ago

This is fixed in current master it seems