brantje / nextnote

A full Evernote / OneNote style WYSIWYG note editor for Nextcloud / ownCloud. Join our telegram at: https://t.me/NextNote
GNU Affero General Public License v3.0
163 stars 19 forks source link

Backend refactor #6

Closed brantje closed 7 years ago

brantje commented 7 years ago
enoch85 commented 7 years ago

Dump file sync for now (will be added later in a PR)

Yes please :+1:

enoch85 commented 7 years ago

Just tested this branch and got this:

Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'SELECT n.uid, n.id, n.name, n.grouping, n.shared, n.mtime, n.deleted, p.pid, GROUP_CONCAT(p.note SEPARATOR '') as note FROM oc_ownnote n INNER JOIN oc_ownnote_parts p ON n.id = p.id WHERE `uid` = ? and n.deleted = 0 GROUP BY p.id' with params ["daniel"]: SQLSTATE[42000]: Syntax error or access violation: 1055 Expression #8 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'owncloud_db.p.pid' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

MySQL 5.7

FYI.

brantje commented 7 years ago

Yea, already thought that the joins would cause trouble on some databases. Guess i'll replace them with a foreach loop and a select.

brantje commented 7 years ago

Whoop scrutinizer is happy!

enoch85 commented 7 years ago

@brantje Will this work or is it still deactivated?