brantje / nextnote

A full Evernote / OneNote style WYSIWYG note editor for Nextcloud / ownCloud. Join our telegram at: https://t.me/NextNote
GNU Affero General Public License v3.0
163 stars 19 forks source link

Add transifex config #87

Closed MorrisJobke closed 6 years ago

MorrisJobke commented 6 years ago

Fixes https://github.com/brantje/nextnote/issues/16

MorrisJobke commented 6 years ago

@nextcloud-bot needs to be admin to be able to push to master.

enoch85 commented 6 years ago

@nextcloud-bot needs to be admin to be able to push to master.

@brantje Do you fix that?

brantje commented 6 years ago

Ya already done =)

MorrisJobke commented 6 years ago

Ah ... pushing the existing stuff isn't that easy sadly :/

brantje commented 6 years ago

You have my permission to nuke it. Translations aren't yet build in into the frontend.

MorrisJobke commented 6 years ago

Ah ... okay, then we will start with a fresh one from transifex.

MorrisJobke commented 6 years ago

@brantje Could you add the bot as admin? So it can push to a protected master branch ;)

brantje commented 6 years ago

Oh crap, forgot that it was protected. Let me check how i can make the bot an admin.

brantje commented 6 years ago

I've unprotected the branch for now, don't see an option to make @nextcloud-bot admin.

MorrisJobke commented 6 years ago

I've unprotected the branch for now, don't see an option to make @nextcloud-bot admin.

Please keep it protected. You need to add the nextcloud bot as collaborator and then set the permission from "write" to "admin".

MorrisJobke commented 6 years ago

It was not about the protected-ness, but rather that admins can ignore the other branch enforcements (like one needed review or passed CI checks).

brantje commented 6 years ago

Thats the thing, i don't see that option: image

MorrisJobke commented 6 years ago

Thats the thing, i don't see that option:

-.- This is sadly not possible for personal repositories. Then at least protect the branch again but remove all the needed checks:

bildschirmfoto 2018-04-12 um 10 39 19
brantje commented 6 years ago

Done! Github should enable that option for personal repo's imo.

MorrisJobke commented 6 years ago

https://github.com/brantje/nextnote/commit/e6dddb05a46dd39e0e722a62fbf31031698c9b49

brantje commented 6 years ago

Awesome thanks! How ever i'm seeing strings like Quick Save which are in l10n but not my app. Not that it matter, just something i noticed.

brantje commented 6 years ago

Oh didn't know i could just remove them. Thanks again =)

MorrisJobke commented 6 years ago

it will clean up automatically all unused stuff. ;) So it's the automatic approach and you should not care anymore about anything from now on ;)

brantje commented 6 years ago

Ah nice.

brantje commented 6 years ago

@MorrisJobke Is there somehere an overview of what langauge codes OC.getLocale() could return? Or even better would it be possible to get the locale like this: en_GB or en_CA?

MorrisJobke commented 6 years ago

@MorrisJobke Is there somehere an overview of what langauge codes OC.getLocale() could return? Or even better would it be possible to get the locale like this: en_GB or en_CA?

Depends on which languages are translated more than 50% (for the core resource), but both you named don't have a team yet so they will not be returned as of now, but it could be in the future. As of now this is the list: https://github.com/nextcloud/server/tree/master/core/l10n

But be aware that it could change anytime depending on the translation status.

brantje commented 6 years ago

Good point. I'll describe my problem. I use tinymce for the editor, so logically i need to change that language too, which is done by the language parameter, which fetches an external JS file.

Here is an overview of the language folder: image As you see, Nextcloud and TinyMCE use different 'keys' to identify them.

I think a mapper would do, but if i could get away with something like OC.getLocale().str_replace('-','_') that would be better.

MorrisJobke commented 6 years ago

For our moment we just try to set it and in case it is there is uses it - in case there is no such language it just uses English. So there is no mapping needed because the language code are the same (also for tinymce they are the same). So should work there too.