Closed MorrisJobke closed 6 years ago
@nextcloud-bot needs to be admin to be able to push to master.
@nextcloud-bot needs to be admin to be able to push to master.
@brantje Do you fix that?
Ya already done =)
Ah ... pushing the existing stuff isn't that easy sadly :/
You have my permission to nuke it. Translations aren't yet build in into the frontend.
Ah ... okay, then we will start with a fresh one from transifex.
@brantje Could you add the bot as admin? So it can push to a protected master branch ;)
Oh crap, forgot that it was protected. Let me check how i can make the bot an admin.
I've unprotected the branch for now, don't see an option to make @nextcloud-bot admin.
I've unprotected the branch for now, don't see an option to make @nextcloud-bot admin.
Please keep it protected. You need to add the nextcloud bot as collaborator and then set the permission from "write" to "admin".
It was not about the protected-ness, but rather that admins can ignore the other branch enforcements (like one needed review or passed CI checks).
Thats the thing, i don't see that option:
Thats the thing, i don't see that option:
-.- This is sadly not possible for personal repositories. Then at least protect the branch again but remove all the needed checks:
Done! Github should enable that option for personal repo's imo.
Awesome thanks! How ever i'm seeing strings like Quick Save
which are in l10n but not my app.
Not that it matter, just something i noticed.
Oh didn't know i could just remove them. Thanks again =)
it will clean up automatically all unused stuff. ;) So it's the automatic approach and you should not care anymore about anything from now on ;)
Ah nice.
@MorrisJobke Is there somehere an overview of what langauge codes OC.getLocale()
could return? Or even better would it be possible to get the locale like this: en_GB
or en_CA
?
@MorrisJobke Is there somehere an overview of what langauge codes OC.getLocale() could return? Or even better would it be possible to get the locale like this: en_GB or en_CA?
Depends on which languages are translated more than 50% (for the core
resource), but both you named don't have a team yet so they will not be returned as of now, but it could be in the future. As of now this is the list: https://github.com/nextcloud/server/tree/master/core/l10n
But be aware that it could change anytime depending on the translation status.
Good point.
I'll describe my problem.
I use tinymce for the editor, so logically i need to change that language too, which is done by the language
parameter, which fetches an external JS file.
Here is an overview of the language folder:
As you see, Nextcloud and TinyMCE use different 'keys' to identify them.
I think a mapper would do, but if i could get away with something like OC.getLocale().str_replace('-','_')
that would be better.
For our moment we just try to set it and in case it is there is uses it - in case there is no such language it just uses English. So there is no mapping needed because the language code are the same (also for tinymce they are the same). So should work there too.
Fixes https://github.com/brantje/nextnote/issues/16