search

braposo / react-text-loop

Animate words in your headings
https://codesandbox.io/s/react-text-loop-playground-br4q1
MIT License
878 stars 65 forks source link

"No tests available" #39

Closed thatzacdavis closed 4 years ago

thatzacdavis commented 4 years ago

Would you mind if I started by adding in some basic tests?

braposo commented 4 years ago

hey @thatzacdavis that sounds amazing! I wanted to add more robustness to the long for a long time, but only managed to convert it to TS so far. Having tests would be great!

Let me know how that goes, ideally it would use jest + react-testing-library if you test any UI components.

Thanks!

thatzacdavis commented 4 years ago

That's my specialty! Be on the lookout for a PR this week.

On Sat, Oct 26, 2019, 5:01 PM Bernardo Raposo notifications@github.com wrote:

hey @thatzacdavis https://github.com/thatzacdavis that sounds amazing! I wanted to add more robustness to the long for a long time, but only managed to convert it to TS so far. Having tests would be great!

Let me know how that goes, ideally it would use jest + react-testing-library if you test any UI components.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/braposo/react-text-loop/issues/39?email_source=notifications&email_token=ACFJNBOAN773F3C72BFBTKLQQSV2RA5CNFSM4JFKDNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKQZUA#issuecomment-546639056, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFJNBN6Y22PWB6OKY5PBVTQQSV2RANCNFSM4JFKDNLA .

thatzacdavis commented 4 years ago

Of course! Happy to help, and provide a jumping off point. I hope to be able to start doing more "real" tests now as well.