search

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

Zoom the barcode #262

Open bracuphoth opened 6 years ago

bracuphoth commented 6 years ago

I installed the app on a 8" screen tablet. And I discovred that even the portrait version is way too big for the scanner. With a 5" telephone screen everything works fine.

brarcher commented 6 years ago

Hm. So the barcode can be too big. Right now there is a max width 1500 pixels for 1D barcodes as 500 pixels for 2D barcodes. Maybe that is still too big for some devices.

Can you tell me what kind of device you have? I can create a simulator and see what you are seeing.

bracuphoth commented 6 years ago

It's a Kindle Fire 8", the 2017 model

OmlineEditor commented 4 years ago

Add the ability to resize the barcode. This is a very useful and necessary feature. Now the size of the barcode is very large. The barcode size must be calculated based on the screen size in pixels and the pixel density (dots per inch) on the screen. then the size on all devices will be the same. add a new function to change the size of the barcode and calculate it using the formula

clach04 commented 4 years ago

I've linked a few issues where if there was a manual zoom (maybe ideally pinch, but plus/minus zoom buttons might help) some of these issues would have at worst a workaround and in some cases final solution.

I agree it would be cool if there was code to handle DPI but manual override would solve multiple issues. Does this warrant a new issue/enhancement request?

TheLastProject commented 4 years ago

I think a new issue for DPI may be best, and just leaving this for zooming. Worst case scenario, one pull request can solve both issues if they end up being "too related". In my honest opinion, at least.