brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
172 stars 29 forks source link

Is Card Data Encrypted In The App? #284

Open trymeouteh opened 5 years ago

trymeouteh commented 5 years ago

Is the card data readable by other apps or is it encrypted to ensure third part apps and malware cannot obtain the card data?

If this is not the case I would like suggest to have the app data encrypted.

brarcher commented 5 years ago

Card data is not encrypted at rest. Instead, it uses internal app storage. The Android protection model for this is that only the specific app is allowed to access that data.

trymeouteh commented 5 years ago

Wouldn't be more secure and safer to encrypt the app data? The app could store gift cards which have some value like money.

brarcher commented 5 years ago

It would be safer, for those Android devices that support a Trusted Execution Environment for Keystore. At this time I will not be working on that, however if someone were interested in contributing the needed changes I'd be glad to review them.