search

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

Fix dark mode scanning issues #329

Closed TheLastProject closed 4 years ago

TheLastProject commented 4 years ago

Fixes #328, hopefully. Will leave this pull request in WIP until I have confirmed it does work in the store.

TheLastProject commented 4 years ago

No longer WIP, just scanned it at the store and it worked great on the dark theme too :)

TheLastProject commented 4 years ago

So I found out today (by running a version of the app without this patch) that the code does scan eventually if you fiddle around enough. But this patch makes it scan instantly like on the light theme

TheLastProject commented 4 years ago

I actually managed to successfully scan with dark mode without this patch several times now. I guess I just had bad luck that one time. Closing this pull request.

TheLastProject commented 4 years ago

I really think this January 16th review relates to this issue: https://play.google.com/store/apps/details?id=protect.card_locker&reviewId=gp%3AAOqpTOHzh05DfQXkszJjd44vsd_rQTPDkPntBJLhyHOWa3OfTSlVdi0yOEZCsuUcHUzPbCfRMLJ-pCPW_eGSx8Q

I still constantly need to switch to light mode at my local supermarket too to have the code scanned.

Seeing this example, CVS has the exact same barcode format as my grocery store too: image

Note the extra white spacing around the barcode that this pull requests will add.

brarcher commented 4 years ago

Sounds good. I'll merge this change in and cut a release.