search

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

Fix converting loyalty card to barcodeless #336

Closed TheLastProject closed 4 years ago

TheLastProject commented 4 years ago

The LoyaltyCardEditActivity assumes on many places that an empty string means it doesn't know a value yet. This patch ensures that the BarcodeSelectorActivity returns a special string so that the LoyaltyCardEditActivity can distinguish explicitly picking no barcode from a not yet populated field.

Fixes #335. It does feel a bit hacky though...

This change is Reviewable