search

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

WIP: Multiple barcode support #337

Open TheLastProject opened 4 years ago

TheLastProject commented 4 years ago

After seeing #279, I felt the tabs were a good way to support multiple barcodes.

Fixes #264 and I feel it also fixes #279 (because multiple barcodes per store make this possible, just note what the code is for). I am also going to assume this fixes #286 as the user's primary concern seems to be an easier way to add another card from a store they already have.

This code groups together every loyalty card with the same store name and, if multiple loyalty cards with the same store name exist, adds a scrollable tabview to switch between them. The text on each tab is based on the note. If there is no note for that specific loyalty card, it falls back to numbering them. It also switches to using a floating action button. Clicking the "+" button when viewing a loyalty card will start the edit activity with the store name pre-filled, to make adding additional cards to the same store easy.

Some screenshots: photo_2020-01-05_00-41-56 photo_2020-01-05_00-41-57 photo_2020-01-05_00-42-00 photo_2020-01-05_00-42-01

TheLastProject commented 4 years ago

photo_2020-01-05_16-46-46 This is a bit of an issue though... Not sure how to fix it... kinda always was an issue but this new feature definitely makes it worse...

TheLastProject commented 4 years ago

I moved the tab bar into the header, which at least makes the situation not worse than it used to be. photo_2020-01-06_21-57-01

TheLastProject commented 4 years ago

This sadly seems to conflict with the feature introduced in #348 and I'm not quite sure how to fix that :(