It's a small but good difference, a "start" so to say (Android layout code is very frustrating and I don't feel like spending more time on it).
The code changes may seem very big, but they are in fact pretty small:
I created a copy of the current view theme in layout-land for landscape layouts, and slightly tweaked the TextView
I added some extra lines to the tests to ensure we run all the tests in landscape view as well, so errors in the landscape layout won't go unnoticed
The other option was to write code in the LoyaltyCardViewActivity class to check the orientation and make some UI changes. While this would be less code and less (UI) code duplication, I felt patching around in the UI like that when Android provides a native mechanism would be less maintainable, which is why I opted for this way of implementing the change.
If you have any more suggestions on how the landscape UI can be tweaked please mention it, I'm honestly not quite sure what to do while keeping it as pretty as it currently is.
Improves #268
Before:
After:
It's a small but good difference, a "start" so to say (Android layout code is very frustrating and I don't feel like spending more time on it).
The code changes may seem very big, but they are in fact pretty small:
The other option was to write code in the LoyaltyCardViewActivity class to check the orientation and make some UI changes. While this would be less code and less (UI) code duplication, I felt patching around in the UI like that when Android provides a native mechanism would be less maintainable, which is why I opted for this way of implementing the change.
If you have any more suggestions on how the landscape UI can be tweaked please mention it, I'm honestly not quite sure what to do while keeping it as pretty as it currently is.