brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

ITF Barcode missing #345

Open 4Nightmares opened 4 years ago

4Nightmares commented 4 years ago

I miss ITF Barcodes Aka interleaved-two-of-five. Would it be possible to add?

TheLastProject commented 4 years ago

Looking at the code, it does seem ITF is supported. Where exactly are you having issues? Scanning? Manually picking the barcode type? Something else?

4Nightmares commented 4 years ago

Yes, this was for manual adding. Scanning works, but I No longer have that Card.

brarcher commented 4 years ago

That is, it is not possible to manually add a ITF barcode? I'm finding that on a test device it does allow manually creating a ITF barcode. Wikipedia says that it must be 14 digits, and in the activity to enter a code directly ITF is shown as an option for the input "12345678901234":

image

(The titles next to the barcodes are from not yet committed https://github.com/brarcher/loyalty-card-locker/pull/333)

Are you able to give more details on how you are finding ITF barcode manual entry not working? It would help in tracking down the issue.

4Nightmares commented 4 years ago

Ah ok, My code only has 6 digits and therefor also has less lines than your example. Not a big deal, I used another app on another phone to have the code generated and, after scanning, it is on loyalty-card-locker now. The code is from a German company called "engelhorn".

TheLastProject commented 4 years ago

Which app did you manage to generate the code with? And if you scan the card with loyalty-card-locker, does it show your 6 digit code as card id or something else?

4Nightmares commented 4 years ago

I used Stocard - even if I do not like to give away personal data. And yes, lcl now shows the 6 digit code.