search

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone
GNU General Public License v3.0
171 stars 29 forks source link

Move barcode to top on tap #348

Closed TheLastProject closed 4 years ago

TheLastProject commented 4 years ago

On a tap of the barcode, moves the barcode to the top of the screen. On another tap, move things back to normal. On the second screenshot, the top bar is normally hidden, it is only visible because creating a screenshot makes it reappear. Fixes #143.

photo_2020-01-19_19-09-08 photo_2020-01-19_19-09-10

This change is Reviewable

devurandom commented 4 years ago

This also works when rotating screens? Is there a setting to always have it at the edge of the screen?

TheLastProject commented 4 years ago

This also works when rotating screens?

Yeah, but it doesn't fix the barcode sizing issues that sometimes happen in landscape view.

Is there a setting to always have it at the edge of the screen?

No, because it really hides everything, also the edit button. So letting this be a default would make a lot of features unreachable. It's just a single tap away, though.

clach04 commented 4 years ago

From quick scan of code (I'm not familiar with the code base) and testing debug build provided for #143 this looks good to me 👍

For the other questions about about additional features - those would be nice to have but I see those as new enhancements (there are issues open for some of those) that could be done in a different PR.

brarcher commented 4 years ago

@TheLastProject, I'm wondering about the barcode entering the status bar. For the 2D barcodes could the app icons interfere with the barcode squares and prevent proper scanning? Should the barcode be below the status bar to prevent scanning issues?

TheLastProject commented 4 years ago

The status bar is actually hidden, but Android force-shows it whenever I try to take a screenshot, so I couldn't show it is hidden normally.

brarcher commented 4 years ago

The status bar is actually hidden, but Android force-shows it whenever I try to take a screenshot, so I couldn't show it is hidden normally.

Oh, I see. You are right. Trying that out on an emulator it is working just fine. Neat. (:

I wonder how a user will discover this feature. (Or almost any feature in the all, really...). Do you think (in a separate PR) adding a new entry to the first start wizard would help? I'm not that familiar with how to help users discover features in apps. Nothing that needs to be solved now, just a thought.

TheLastProject commented 4 years ago

The issue with the first start wizard is that existing users probably won't see it and thus still not know about the new features.

Maybe it'll be interesting to add something like https://steemit.com/utopian-io/@andrixyz/using-material-showcase-view-to-tutor-users-in-android-app-development, so we can highlight interesting new features on new releases and guide new users through how to use the app, replacing the first start wizard entirely with such hints?

clach04 commented 4 years ago

The status bar is actually hidden, but Android force-shows it whenever I try to take a screenshot, so I couldn't show it is hidden normally.

I can confirm this based on testing my device.