v0.28 : Import menu has disappeared

brarcher / loyalty-card-locker

Stores your barcode-based store/loyalty cards on your phone

GNU General Public License v3.0

171 stars 29 forks source link

v0.28 : Import menu has disappeared #364

Open llange opened 4 years ago

llange commented 4 years ago

Since I've switched to 0.28 I cannot import any more. The import/export menu display the import/export page ; however this page only has the "Export" section + button - no more "Import" section. Note:

French locale
Linux localhost 3.10.108-ga0fd64c #1 SMP PREEMPT Fri Jun 15 09:31:54 UTC 2018 armv7l
Android 7.1.2 (samsung/lineage_kccat6/kccat6:7.1.2/NJH47F/4c77d2651b:userdebug/release-keys)
LineageOS 14.1-20180615-NIGHTLY-kccat6

TheLastProject commented 4 years ago

What options did you have in 0.27? This honestly quite surprises me, I really didn't expect an Android 7 device that would lack a way to answer the GET_CONTENT intent

llange commented 4 years ago

Hello @TheLastProject , on 0.27 it looks as expected:

TheLastProject commented 4 years ago

Ah, I see. You were already missing some import options but I indeed broke it completely for you.

As a workaround you could install any file manager, but I'll look into fixing this at some point so you won't have to.

TheLastProject commented 4 years ago

Oh, another thing.

Could you tell me if the export function works on your device? Because that uses the internal file manager now too. I'm trying to understand on what layer things go wrong.

llange commented 4 years ago

@TheLastProject thanks a lot for your comments. I do have (multiple) file managers here : among which I have:

https://f-droid.org/en/packages/com.veniosg.dir/
LineageOS default file manager (I believe it's https://github.com/LineageOS/android_packages_apps_DocumentsUI )
OI FileManager 2.2.3

In 0.28 I'm able to export : It launches the default file manager where I'm able to navigate and modify the file name, and then the export seems OK:

Even if the filename looks strange, it has been created at the proper place with proper content.

llange commented 4 years ago

Wait ! I found it.

I'm using XPrivacyLua, and starting from 0.28 it interacts by filtering some part of the import/export screen.

By disabling the checkbox "See installed applications" ; everything is now back and I can see the other options:

I'm sorry for the report - perhaps we may add a small info about this new behaviour in the README or the release notes ?

TheLastProject commented 4 years ago

I'm so glad you found it and thanks for sharing what it was, it's very interesting to learn how XPrivacyLua interacts with things!

There may be ways this can be improved, yeah. I don't think mentioning XPrivacyLua in the README is really worth it but the app should probably deal more gracefully with no file manager being found.

llange commented 4 years ago

Thanks a lot for your comment !

I'm suggesting closing it as a solution was found - may be you want to open a distinct (related) issue regarding the lack of file manager ? Or if you want you can keep this one open instead.

TheLastProject commented 4 years ago

I think keeping this open would be fine, as it has more context. Unless @brarcher disagrees.

brarcher commented 4 years ago

Keeping this open is fine. XPrivacyLua uses Xposed, and that is a bit down the rabbit hole to mention in the README. The CHANGELOG does mention a change to importing/exporting.