brarcher / protect-baby-monitor

Android-based Baby Monitor
GNU General Public License v3.0
63 stars 32 forks source link

Translation to German #33

Closed ghost closed 6 years ago

ghost commented 6 years ago

I have only translate to german.

brarcher commented 6 years ago

I received a request today on Transifex for translating German, was that from you? If so, the items which need translated for the UI are the strings available on Transifex. I would encourage you to work through those strings. When you are finished, if you ping me to remind me, I'll pick them up for the next release.

Your pull request here translates debug logs which are not available to a user from the UI. Really, the logs are for me (or a developer) to diagnose why something is going wrong. Did you intent to translate the debug logging or the user interface strings?

As is, I will not accept this pull request, as it would remove my ability to debug the application. If you are interested in localizing the debug logging, additional strings would need to be added for each message and translated, then those strings used in the log statements. Though, if your intention is to translate the UI, all this is unnecessary.

ghost commented 6 years ago

Hi

I received a request today on Transifex for translating German, was that from you? If so, the items which need translated for the UI are the strings available on Transifex. I would encourage you to work through those strings. When you are finished, if you ping me to remind me, I'll pick them up for the next release.

Now i have translate your App with Transifex.

Your pull request here translates debug logs which are not available to a user from the UI. Really, the logs are for me (or a developer) to diagnose why something is going wrong. Did you intent to translate the debug logging or the user interface strings?

This was my first expierence to translate a App from Github. Now I know to use Transifex.

As is, I will not accept this pull request, as it would remove my ability to debug the application. If you are interested in localizing the debug logging, additional strings would need to be added for each message and translated, then those strings used in the log statements. Though, if your intention is to translate the UI, all this is unnecessary.

It`s Ok. I hope my translation help you.

Excuse me my bad english. I can read something and understand but Im not so good at writing.

naliasc aka nac

brarcher commented 6 years ago

Now i have translate your App with Transifex.

I've picked up the translations in https://github.com/brarcher/protect-baby-monitor/pull/34, thanks.

This was my first expierence to translate a App from Github. Now I know to use Transifex.

Some projects use Transifex and others do not. I think it is easier for someone to use Transifex than to submit a pull request.

I hope my translation help you.

Thanks! Hopefully others who want to use the app but want it to be in German will benefit.

I'm closing this pull request.