search

brarcher / video-transcoder

Android app for video and audio transcoder, based on FFmpeg
GNU General Public License v3.0
486 stars 56 forks source link

updated dependencies and gradles #113

Closed TacoTheDank closed 6 years ago

brarcher commented 6 years ago

I think the build failed because ProGuard is hitting some symbols it does not know what to do about. My guess is the Guava update. You may want to try to build locally and get the ProGuard stuff worked out then try again.

TacoTheDank commented 6 years ago

ill try 23.0 for guava, since its the latest version that doesn't include a "-[word]" after it

brarcher commented 6 years ago

Curious, what is the drive for updating the dependencies? There are no CVEs out against these that would affect the application. Do you have subsequent changes planned which need these?

TacoTheDank commented 6 years ago

no particular reason, i just feel like it would be better to be up-to-date (as long as they produce no ill effects, of course)

brarcher commented 6 years ago

Have you had a chance to test it locally for regressions? The automated tests check that an ENCODE intent can be received and a file can be encoded, but the general UI is not tested at this point.

TacoTheDank commented 6 years ago

oh. no i havent

brarcher commented 6 years ago

Are you in a position where you can do a spot check, to see if with the updates you are able to select a video file, play with the sliders, and encode a file?

TacoTheDank commented 6 years ago

i mean, ill try... ill build an apk and test it on my phone

TacoTheDank commented 6 years ago

i built a debug and a release apk from my fork (they're both signed with my key as well, so youll have to uninstall the app if you have it installed) - ill put the build file with the apks here in case you'd like to test it as well (screw you github and your 10MB limit >:c i have to put it on a cloud and make it shareable lol)

https://mega.nz/#F!0TA2zAQB!U2P08W5sdOlXuBMGfUWbOw

brarcher commented 6 years ago

lol, yeah, I know the apk is pretty big.

Just let me know if you find any issues. If there are, we'll need to figure them out. If not, I'll accept the PR.

TacoTheDank commented 6 years ago

kk

TacoTheDank commented 6 years ago

(also i uploaded the apks above if you didnt see that, cause i was editing that comment when you commented)

brarcher commented 6 years ago

Did you find anything in your testing?

TacoTheDank commented 6 years ago

ah shit i forgot lmao

TacoTheDank commented 6 years ago

ok I finally had the chance to test it, and yeah it works

brarcher commented 6 years ago

I tried it out as well. I found that Android Studio did not like to build it due to an incompatibility with the Gradle version and the Android plugin. Getting around that, the app itself seemed to work just fine.

I pushed my workaround. Once that passes, I'll merge the request.

TacoTheDank commented 6 years ago

oh yeah the configure on demand thing